Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: constants #1094

Merged
merged 1 commit into from
Aug 19, 2021
Merged

fix: constants #1094

merged 1 commit into from
Aug 19, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Aug 9, 2021

  • move once used const to the chunk
  • remove unused const

@akellbl4 akellbl4 requested a review from Mavrin August 9, 2021 14:15
@akellbl4 akellbl4 requested a review from umputun as a code owner August 9, 2021 14:15
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1094 (aa7cbec) into master (cac1eb2) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   47.38%   47.33%   -0.06%     
==========================================
  Files         134      134              
  Lines        2942     2941       -1     
  Branches      658      658              
==========================================
- Hits         1394     1392       -2     
- Misses       1538     1539       +1     
  Partials       10       10
Impacted Files Coverage Δ
frontend/app/common/constants.config.ts 100.00% <ø> (ø)
frontend/app/common/constants.ts 90.00% <ø> (-0.48%) ⬇️
frontend/app/counter.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5668614...aa7cbec. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

size-limit report 📦

Path Size
public/embed.mjs 1.9 KB (0%)
public/remark.mjs 66.19 KB (0%)
public/remark.css 9.42 KB (0%)
public/last-comments.mjs 30.14 KB (0%)
public/last-comments.css 5.06 KB (0%)
public/deleteme.mjs 9.79 KB (0%)
public/counter.mjs 601 B (0%)

@akellbl4
Copy link
Collaborator Author

@umputun it's good to merge

@umputun umputun merged commit 5718a69 into master Aug 19, 2021
@umputun umputun deleted the consts branch August 19, 2021 17:55
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mavrin Mavrin Mavrin approved these changes

@umputun umputun Awaiting requested review from umputun umputun is a code owner

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akellbl4 @Mavrin @umputun @paskal